Skip to content

Conversation

@SirYwell
Copy link
Member

Overview

Fixes #2944

Description

Not setting the block with its default NBT data results in the (vanilla) client not rendering the blocks properly. We should also probably pull upstream changes in that area at some point, but that didn't look as straightforward as this fix.

### Submitter Checklist
- [x] Make sure you are opening from a topic branch (**/feature/fix/docs/ branch** (right side)) and not your main branch.
- [x] Ensure that the pull request title represents the desired changelog entry.
- [x] New public fields and methods are annotated with `@since TODO`.
- [x] I read and followed the [contribution guidelines](https://github.com/IntellectualSites/.github/blob/main/CONTRIBUTING.md).

@SirYwell SirYwell requested a review from a team as a code owner October 12, 2024 14:23
@github-actions github-actions bot added the Bugfix This PR fixes a bug label Oct 12, 2024
Copy link
Member

@PierreSchwang PierreSchwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good I guess.
I think we should apply upstream changes rather sooner than later, so that NBT data can be specified as well - so that would probably address that as well, kind of (https://worldedit.enginehub.org/en/latest/usage/general/patterns/#single-block-pattern)

@PierreSchwang PierreSchwang requested a review from a team October 17, 2024 21:19
@dordsor21 dordsor21 merged commit 65de364 into main Oct 24, 2024
@dordsor21 dordsor21 deleted the fix/block-parser-nbt branch October 24, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bugfix This PR fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

//set oak_sign places invisible signs

5 participants