Fix vectorized CountFilter #2943
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Description
The
applyVectorimplementation ofCountFilterjust counted the number of lanes it sees, which doesn't match the behavior of the scalar implementation. By passing around a mask for the affected lanes, we can just count those lanes and get the same counts as without vectorization. We can also move some of the blending code to the pattern rather than the mask, which is also clearer I think.