Skip to content

Conversation

@SirYwell
Copy link
Member

Overview

Description

The applyVector implementation of CountFilter just counted the number of lanes it sees, which doesn't match the behavior of the scalar implementation. By passing around a mask for the affected lanes, we can just count those lanes and get the same counts as without vectorization. We can also move some of the blending code to the pattern rather than the mask, which is also clearer I think.

### Submitter Checklist
- [x] Make sure you are opening from a topic branch (**/feature/fix/docs/ branch** (right side)) and not your main branch.
- [x] Ensure that the pull request title represents the desired changelog entry.
- [x] New public fields and methods are annotated with `@since TODO`.
- [x] I read and followed the [contribution guidelines](https://github.com/IntellectualSites/.github/blob/main/CONTRIBUTING.md).

@SirYwell SirYwell requested a review from a team as a code owner October 10, 2024 19:33
@github-actions github-actions bot added the Bugfix This PR fixes a bug label Oct 10, 2024
@NotMyFault NotMyFault requested a review from a team October 20, 2024 09:56
@NotMyFault NotMyFault merged commit 7d6643b into main Oct 25, 2024
@NotMyFault NotMyFault deleted the fix/vectorized-counting branch October 25, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bugfix This PR fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants