Fix: Copy-Paste-Brush with falsy mask #2899
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes a bug shared on discord.
Description
Use copypaste-brush (
//br copypaste) with a falsy mask (e.g.//gmask 0) and select the area via the first click / interact. Output should state, that0 blocks were copied.. Attempting to paste with that brush, results in no future actions being possible (potentially depending on the queue type).That's due to the
ResizableClipboardBuilder. As the mask did not match any blocks, no blocks were added to the builder. Therefor, on build the default dimensions are used, which results in the region spanning from XYZ Integer.MAX_VALUE to XYZ Integer.MIN_VALUE. The RegionVisitor - called by the ForwardExtentCopy - attempts to load all chunks in that range via the SingleThreadQueueExtent.The fix is simply using an
EmptyClipboardif nothing was being written into theResizableClipboardBuilder.