Skip to content

Conversation

@SirYwell
Copy link
Member

@SirYwell SirYwell commented Aug 14, 2024

Overview

Fixes #2818
Fixes #2861

Description

We can greatly simplify the regeneration logic by relying on the server's chunk system instead of trying to run the generation ourselves. This works well on Paper, and probably good enough on Spigot. Conceptually, the change is similar to how a //lazycopy would work, just with the temporary world as a source. I think this is far better in terms of maintainability.

Tested on Paper 1.21(.1), only, but the code should work on older versions too and as there isn't much low-level implementation details, I also expect Spigot to work.

### Submitter Checklist
- [x] Make sure you are opening from a topic branch (**/feature/fix/docs/ branch** (right side)) and not your main branch.
- [x] Ensure that the pull request title represents the desired changelog entry.
- [x] New public fields and methods are annotated with `@since TODO`.
- [x] I read and followed the [contribution guidelines](https://github.com/IntellectualSites/.github/blob/main/CONTRIBUTING.md).

@SirYwell SirYwell requested a review from a team as a code owner August 14, 2024 19:47
@github-actions github-actions bot added the Bugfix This PR fixes a bug label Aug 14, 2024
@Kadeluxe
Copy link

Works well and much faster than previous implementation, good job and thank you

@illyrius666
Copy link

can we get this merged asap? kinda need it :)

@dordsor21 dordsor21 requested a review from a team September 6, 2024 12:18
@NotMyFault NotMyFault merged commit e8c7d67 into main Sep 14, 2024
@NotMyFault NotMyFault deleted the fix/regen-again branch September 14, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bugfix This PR fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

//regen consistently taking around 10 minutes Regen support for 1.21

6 participants