Skip to content

Conversation

@SirYwell
Copy link
Member

Overview

Description

Noise-based patterns can benefit from allowing the same pattern multiple times, e.g. #simplex[10][red_wool,blue_wool,red_wool,green_wool] maps random values from [0, 1) to [red_wool, blue_wool, red_wool, green_wool] ([0, 0.25) -> red_wool and [0.5, 0.75) -> red_wool), while before, red_wool was just added up to have a weight of 2.

Additionally, we move the random instance out of the collection. The collection doesn't actually depend on a (stateful) random, so that's a bit cleaner.

### Submitter Checklist
- [x] Make sure you are opening from a topic branch (**/feature/fix/docs/ branch** (right side)) and not your main branch.
- [x] Ensure that the pull request title represents the desired changelog entry.
- [x] New public fields and methods are annotated with `@since TODO`.
- [x] I read and followed the [contribution guidelines](https://github.com/IntellectualSites/.github/blob/main/CONTRIBUTING.md).

@SirYwell SirYwell requested a review from a team as a code owner March 16, 2024 11:27
@github-actions github-actions bot added the Feature This PR adds a new feature label Mar 16, 2024
@NotMyFault NotMyFault merged commit 472eb19 into v3 Mar 16, 2024
@NotMyFault NotMyFault deleted the feature/v3/improve-random-collections branch March 16, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature This PR adds a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants