refactor: apply final/abstract to various fawe extent classes #2615
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Thoughts? |
Member
|
That's breaking in theory, would it make sense to target v3 instead? |
Member
Author
|
Ah yeah had meant to do that |
Member
Author
|
I'll fix this lol |
dordsor21
force-pushed
the
refactor/make-extents-final-and-abstract
branch
from
7add936 to
acda71b
Compare
SirYwell
reviewed
Mar 16, 2024
worldedit-core/src/main/java/com/fastasyncworldedit/core/extent/TransformExtent.java
Outdated
Show resolved
Hide resolved
Member
|
You removed the comment from |
Member
Author
Yeah I realised it was a WE class |
SirYwell
approved these changes
Mar 16, 2024
SirYwell
pushed a commit
that referenced
this pull request
Aug 22, 2024
* refactor: apply final/abstract to various fawe extent classes * Remove forremoval as targets v3
dordsor21
added a commit
that referenced
this pull request
Sep 26, 2024
* refactor: apply final/abstract to various fawe extent classes * Remove forremoval as targets v3
SirYwell
pushed a commit
that referenced
this pull request
Oct 26, 2024
* refactor: apply final/abstract to various fawe extent classes * Remove forremoval as targets v3
SirYwell
pushed a commit
that referenced
this pull request
Oct 26, 2024
* refactor: apply final/abstract to various fawe extent classes * Remove forremoval as targets v3
dordsor21
added a commit
that referenced
this pull request
Jul 25, 2025
* refactor: apply final/abstract to various fawe extent classes * Remove forremoval as targets v3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.