-
-
Notifications
You must be signed in to change notification settings - Fork 311
feat: make more commands unqueued #2235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dordsor21
commented
May 20, 2023
- Effectively fixes the very specific "issue" in FAWE temporarily stops working after //replacenear and "Relighter factory" console message #2223 I guess
- Use this opportunity to clean up the command classes a bit
- Effectively fixes the very specific "issue" in #2223 I guess - Use this opportunity to clean up the command classes a bit
Closed
2 tasks
Closed
2 tasks
SirYwell
requested changes
May 20, 2023
worldedit-core/src/main/java/com/sk89q/worldedit/command/BrushCommands.java
Outdated
Show resolved
Hide resolved
worldedit-core/src/main/java/com/sk89q/worldedit/command/ClipboardCommands.java
Outdated
Show resolved
Hide resolved
NotMyFault
reviewed
May 20, 2023
worldedit-core/src/main/java/com/sk89q/worldedit/command/SelectionCommands.java
Outdated
Show resolved
Hide resolved
3a73511 to
63c8b9c
Compare
SirYwell
approved these changes
May 21, 2023
NotMyFault
approved these changes
May 22, 2023
dordsor21
pushed a commit
that referenced
this pull request
Mar 13, 2025
* Add a -c flag to the biome brush to set entire column * Use new region factories that take fixed positions * Rename to FixedHeight from just Fixed
dordsor21
pushed a commit
that referenced
this pull request
Mar 24, 2025
* Add a -c flag to the biome brush to set entire column * Use new region factories that take fixed positions * Rename to FixedHeight from just Fixed
NotMyFault
pushed a commit
that referenced
this pull request
Apr 5, 2025
* Add data from MCUtils for 1.21 * Fix nbt access in proxy * Lazily compute BlockState#getAsString (#2566) * Lazily compute BlockState#getAsString * Implement in BaseBlock * Remove <1.16 //drawsel max size handling (#2572) * Cleanup registry init (#2583) * Attempt to fix #2125 * Fix SideEffectSet inconsistencies, improve perf The `apply` term was inconsistent in this API, but should have always been the same. This makes the "set" actually store the state of the given effect, even if it's the default, and therefore consistent. * Add property-based testing for SideEffectSet * Changes /curve /line thickness param from int to double (#2623) * Make task executor lifecycled to platform readiness. Closes #2459. * Bump lin-bus to support old schematics better * Data updates for 1.21.2 * [Bukkit] Stop using EnumMap for potential registry types Biome broke in 1.21.3, Material could break in the future * Add parent dir to manifest classpath to account for paper-remapped load point. Currently, the remapped WorldEdit jar on paper is loaded from a sub-directory of the plugins folder, meaning dependencies like truezip and rhino won't be found in the documented search locations. Adding the parent dir temporarily solves this. See #2692. Closes #2691. * Add setBiome override in MaskingExtent. This makes biome operations respect masks set on an EditSession. * Add //mirror as an alias of //flip. (#2714) * Remove never-working caching and fix bugs in region code (#2716) Fixes #2684 * Fix negative height cones. Despite the description/doc stating that negative heights would generate inverted cones, this wasn't actually implemented. * Fix sending CUI packets to unwilling clients. Some servers track channel registration: NF throws an error every time this happens; Bukkit silently drops it; Fabric silently sends it (presumably the client ignores it). * Added a brush for biomes (#1491) * Added a brush for biomes * IntelliJ reformat * Move the warning * Update worldedit-core/src/main/resources/lang/strings.json Co-authored-by: Octavia Togami <octavia.togami@gmail.com> * Use BiomeFactory instead Co-authored-by: Octavia Togami <octavia.togami@gmail.com> * Add morph brush (#2078) * Add erosion brush * Rename to the Morph brush, and add Erode and Dilate presets Co-authored-by: Lewis B <lbobbermen@bigpond.com> * Add a -c flag to the biome brush to set entire column (#2235) * Add a -c flag to the biome brush to set entire column * Use new region factories that take fixed positions * Rename to FixedHeight from just Fixed * Deprecate MultiStageReorder and ReorderMode (#1999) * Start deprecating MultiStage reorder * Rather than changing behaviour just deprecate * Add deprecation message * Apply PR review notes * Add API to disable history tracking in EditSessions (#2189) * Add API to disable history tracking in EditSessions * Update worldedit-core/src/main/java/com/sk89q/worldedit/extent/ChangeSetExtent.java Co-authored-by: Octavia Togami <octavia.togami@gmail.com> Co-authored-by: Octavia Togami <octavia.togami@gmail.com> --------- Co-authored-by: Madeline Miller <mnmiller1@me.com> Co-authored-by: Octavia Togami <octavia.togami@gmail.com> Co-authored-by: Markus Ebner <hiwatari.seiji@gmail.com> Co-authored-by: Tyler Wesley <harvestminer@gmail.com> Co-authored-by: wizjany <wizjany@gmail.com> Co-authored-by: Lewis B <lbobbermen@bigpond.com>
dordsor21
pushed a commit
that referenced
this pull request
Apr 5, 2025
* Add a -c flag to the biome brush to set entire column * Use new region factories that take fixed positions * Rename to FixedHeight from just Fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.