Skip to content

Changes made based on the comments #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 9, 2023

Conversation

AntonStokoz
Copy link

No description provided.


>Authentication API Endpoint - https: // dev-intelex.us.auth0.com/oauth/token
>Authentication API Endpoint - https: // {auth0 Sub-Domain}.auth0.com/oauth/token
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I this we probably just need to mention that you receive instruction on how to authenticate from Intelex Consultant initially, and from the ACTS Web in the future, rather than specifying it here. Also I'd say any details about auth0 should be hidden i.e we should not mention Auth0 in our docs. For the URLs, I think we need to add custom intelex domain to Auth0.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AkshayaKumarIntelex take a look at Anton's comments here

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@heydarli made changes to the URL based on the comments from Anton . You can take a look and provide your approval .

Copy link
Author

@AntonStokoz AntonStokoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think some changes are still needed.

@AntonStokoz AntonStokoz requested a review from heydarli August 2, 2023 16:17
@AkshayaKumarIntelex AkshayaKumarIntelex self-requested a review August 9, 2023 09:35

```
https: // *actsapi.intelex.com/API-develop/v1/EmissionCategory
https: // {tenant}actsapi.intelex.com/API-develop/v1/EmissionCategory
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it API or API-develop? Review other URLs as well

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's API-develop here develop is the environment mentioned here , the final URLs would be changed in the Doc once we finalize the URL and we get the prod environment .

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is public facing documentation, are we releasing /API-develop/ to clients? If not, then it should not be here. Isn't this documentation for prod environment?

Copy link

@AkshayaKumarIntelex AkshayaKumarIntelex Aug 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's public facing documentation and the final URL's would be something different and would be modified in the GA release and currently we still don't have the prod environment ready , so we are using the develop environment URL's for reference.

Copy link

@heydarli heydarli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok, URLs must be reviewed once public

@AkshayaKumarIntelex AkshayaKumarIntelex merged commit 097f7f5 into master Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants