-
Notifications
You must be signed in to change notification settings - Fork 2
Changes made based on the comments #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
||
>Authentication API Endpoint - https: // dev-intelex.us.auth0.com/oauth/token | ||
>Authentication API Endpoint - https: // {auth0 Sub-Domain}.auth0.com/oauth/token |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I this we probably just need to mention that you receive instruction on how to authenticate from Intelex Consultant initially, and from the ACTS Web in the future, rather than specifying it here. Also I'd say any details about auth0 should be hidden i.e we should not mention Auth0 in our docs. For the URLs, I think we need to add custom intelex domain to Auth0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AkshayaKumarIntelex take a look at Anton's comments here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@heydarli made changes to the URL based on the comments from Anton . You can take a look and provide your approval .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think some changes are still needed.
source/includes/_all-get-apis.md
Outdated
|
||
``` | ||
https: // *actsapi.intelex.com/API-develop/v1/EmissionCategory | ||
https: // {tenant}actsapi.intelex.com/API-develop/v1/EmissionCategory |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it API
or API-develop
? Review other URLs as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's API-develop here develop is the environment mentioned here , the final URLs would be changed in the Doc once we finalize the URL and we get the prod environment .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is public facing documentation, are we releasing /API-develop/ to clients? If not, then it should not be here. Isn't this documentation for prod environment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's public facing documentation and the final URL's would be something different and would be modified in the GA release and currently we still don't have the prod environment ready , so we are using the develop environment URL's for reference.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks ok, URLs must be reviewed once public
No description provided.