This repository was archived by the owner on Feb 2, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 62
Fixing perf issue with getitem by Boolean mask #790
Merged
AlexanderKalistratov
merged 2 commits into
IntelPython:master
from
kozlov-alexey:feature/fix_getitem_by_mask_perf
Apr 2, 2020
Merged
Fixing perf issue with getitem by Boolean mask #790
AlexanderKalistratov
merged 2 commits into
IntelPython:master
from
kozlov-alexey:feature/fix_getitem_by_mask_perf
Apr 2, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
densmirn
reviewed
Mar 30, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any performance data?
|
||
return _sdc_take_str_arr_impl | ||
|
||
elif (isinstance(data, types.RangeType) and isinstance(data.dtype, types.Integer)): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool
densmirn
approved these changes
Apr 2, 2020
@AlexanderKalistratov TC builds are failing now, so I re-measured manually on nnlmlp01 (the data size was increased to 5 * 10 ** 7 to increase exec times): With fix:
On master (without fix):
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.