Skip to content
This repository was archived by the owner on Feb 2, 2024. It is now read-only.

Conversation

1e-to
Copy link
Contributor

@1e-to 1e-to commented Mar 25, 2020

No description provided.

@1e-to 1e-to requested review from PokhodenkoSA and akharche March 25, 2020 11:52
.. command-output:: python ./series/series_astype.py
:cwd: ../../../examples
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dtype two times in caption
:caption: Cast a pandas object to a specified dtype dtype.

Limitations
-----------
- Parameter level is currently unsupported by Intel Scalable Dataframe Compiler
- Parameter ``level`` is currently unsupported by Intel Scalable Dataframe Compiler
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be a bit redundant? It's ok in short variant I think

Suggested change
- Parameter ``level`` is currently unsupported by Intel Scalable Dataframe Compiler
- Parameter ``level`` is currently unsupported.

-----------
Parameter ``axis`` is supported only with default value ``None``.
Parameter ``skipna`` cannot be ``False`` with data of string type.
- Parameter ``axis`` is supported only with default value ``None``.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's be more consistent and write either "is supported only with default value" or 'not supported'

- Parameter inplace supported as literal value only
- Parameters ``method``, ``limit`` and ``downcast`` are currently unsupported
by Intel Scalable Dataframe Compiler.
- Parameter ``inplace`` supported as literal value only.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Parameter ``inplace`` supported as literal value only.
- Parameter ``inplace`` is supported with literal value only.

@Hardcode84
Copy link
Contributor

conflict

@AlexanderKalistratov
Copy link
Collaborator

Conflict

@AlexanderKalistratov AlexanderKalistratov merged commit aa6898b into IntelPython:master Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants