Skip to content

Use CLI11 parser for all native benchmarks #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 8, 2019

Conversation

bibikar
Copy link
Contributor

@bibikar bibikar commented May 8, 2019

This PR attempts to resolve some inconsistencies in argument parsing in native benchmarks, and uses CLI11 parser globally for native benchmarks. It also refactors distances, linear/ridge regression, and kmeans benchmarks to use some common code for consistency.

  • Add CLI11 header to repo
  • Combine cosine and correlation distances into one file
  • Use CLI11 in distances, linear/ridge regression, kmeans benches
  • Pass around results of benchmarks for verification if needed (as NumericTablePtr or ResultPtr or std::tuple)
  • General refactoring of benches converted to use CLI11 for easier readability

@bibikar bibikar requested a review from oleksandr-pavlyk May 8, 2019 20:23
Copy link
Contributor

@oleksandr-pavlyk oleksandr-pavlyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bibikar bibikar merged commit fcda222 into IntelPython:master May 8, 2019
@bibikar bibikar deleted the feature/native_cli11 branch August 15, 2019 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants