Skip to content

minor update for kmeans out of preview #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 5, 2025
Merged

Conversation

ethanglaser
Copy link
Contributor

@ethanglaser ethanglaser commented Jan 21, 2025

Description

Remove preview module for kmeans as kmeans is out of preview (uxlfoundation/scikit-learn-intelex#1770)


PR should start as a draft, then move to ready for review state after CI is passed and all applicable checkboxes are closed.
This approach ensures that reviewers don't spend extra time asking for regular requirements.

You can remove a checkbox as not applicable only if it doesn't relate to this PR in any way.

Checklist to comply with before moving PR from draft:

PR completeness and readability

  • I have reviewed my changes thoroughly before submitting this pull request.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes or created a separate PR with update and provided its number in the description, if necessary.
  • Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details).
  • I have added a respective label(s) to PR if I have a permission for that.
  • I have resolved any merge conflicts that might occur with the base branch.

Testing

  • I have run it locally and tested the changes extensively.
  • All CI jobs are green or I have provided justification why they aren't.
  • I have extended testing suite if new functionality was introduced in this PR.

@david-cortes-intel
Copy link
Contributor

Thanks, I can confirm that regular/kmeans.json now executes without the previous error.

But I see the PR has a large file for SPMD which is not only about KMeans - was it committed accidentally? Otherwise, might be better left for a different PR.

@ethanglaser
Copy link
Contributor Author

/azp run CI

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@david-cortes-intel
Copy link
Contributor

/azp run CI

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ethanglaser ethanglaser added the bug Something isn't working label Mar 5, 2025
@ethanglaser ethanglaser marked this pull request as ready for review March 5, 2025 22:30
@ethanglaser ethanglaser merged commit 88fd9c8 into main Mar 5, 2025
18 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants