Skip to content

update n_init for kmeans #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 28, 2024
Merged

Conversation

md-shafiul-alam
Copy link
Contributor

@md-shafiul-alam md-shafiul-alam commented Aug 8, 2024

@Alexsandruss
Copy link
Contributor

@md-shafiul-alam

Change normalize to false

But why? KMeans inertia is sensitive to normalization

@md-shafiul-alam
Copy link
Contributor Author

@md-shafiul-alam

Change normalize to false

But why? KMeans inertia is sensitive to normalization

Only reason is that stock scikit learn does not have any option for normalization.

@Alexsandruss
Copy link
Contributor

data:preprocessing_kwargs:normalize is not argument of an estimator

@md-shafiul-alam
Copy link
Contributor Author

data:preprocessing_kwargs:normalize is not argument of an estimator

I understand, but is there a specific reason we normalize by default? To me seems like a redundant step.

Copy link
Contributor

@Alexsandruss Alexsandruss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

data:preprocessing_kwargs:normalize is not argument of an estimator

I understand, but is there a specific reason we normalize by default? To me seems like a redundant step.

Normalization is required for algorithms sensitive to it for better quality metrics and representation of user cases.

@md-shafiul-alam
Copy link
Contributor Author

@Alexsandruss Do you suggest any more changes?

@Alexsandruss Alexsandruss merged commit 9b94b00 into IntelPython:main Aug 28, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants