Skip to content

More specific write access message #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

ethanglaser
Copy link
Contributor

@ethanglaser ethanglaser commented Dec 6, 2023

Associated with task: Fix sklearnex_bench errors if DATASETSROOT is not writeable

  • Functionally, the code should already be working as intended - a warning is raised because the path is not writeable, therefore it writes to local path instead. The existing exception is broader so it makes it seem like a problem. Solution is to add a more specific exception for the case where the error is permission denied/not writeable and raise a more specific message. In both cases it's a warning and functionally the same.

@ethanglaser
Copy link
Contributor Author

@ethanglaser ethanglaser marked this pull request as draft December 6, 2023 15:30
@Alexsandruss
Copy link
Contributor

Not relevant after refactoring. New caching scheme requires write access.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants