Skip to content
This repository was archived by the owner on Jan 25, 2023. It is now read-only.

Patch for lowering #98

Closed
wants to merge 1 commit into from

Conversation

PokhodenkoSA
Copy link

This change removes global initialization of lower_extensions
with one functions and replaces with a list of functions.
This change made in commit 947b407 by @reazulhoque.

@AlexanderKalistratov have thoughts to remove this code because with TargetDispatcher it is not effective.

This change removes global initialization of lower_extensions
with one functions and replaces with a list of functions.
This change made in commit 947b407 by @reazulhoque.
@PokhodenkoSA PokhodenkoSA mentioned this pull request Nov 9, 2020
50 tasks
@PokhodenkoSA
Copy link
Author

PokhodenkoSA commented Nov 10, 2020

Need to redesign:

  • Make lowering.lower_extensions not a global variable but a part of context.
  • Until this redesign it could be a patch in our conda-recipe.

This proposal should be discussed with Numba:

  • All nodes processing functions should be defined by context and should not be a defined by global variables.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant