Skip to content
This repository was archived by the owner on Jan 25, 2023. It is now read-only.

Remove unary_sqrt_extern() used for sqrt_impl #87

Merged

Conversation

PokhodenkoSA
Copy link

@PokhodenkoSA PokhodenkoSA commented Nov 5, 2020

This possibly could be a function required to move to upstream but also
it could be a not intended function.

This function was created in b4a325d by @DrTodd13.
Then there was a long branch dedicated to PVC and in 947b407 it was merged with master of Numba by @reazulhoque.
It was released first time in 0.49.1+dppy0.4.0.

@DrTodd13 if this function is not important for the current state of Numba DPPY the I would like to revert it to release0.51 branch of Numba.

This possibly could be a function required to move to upstream but also
it could be a not intended function.

This function was created in b4a325d by @DrTodd13.
Then there was a long branch dedicated to PVC and in
947b407 it was merged with master of Numba bu @reazul.hoque.
It was released in 0.49.1+dppy0.4.0.
@PokhodenkoSA PokhodenkoSA mentioned this pull request Nov 5, 2020
50 tasks
Copy link

@reazulhoque reazulhoque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I spoke with Todd about this a while back when we first started this effort. I tried commenting the change and ran math.sqrt test (I wrote it), I did not find any problem. May be you want to replicate what I did before we decide to remove this piece of code.

@PokhodenkoSA
Copy link
Author

I tried commenting the change and ran math.sqrt test (I wrote it), I did not find any problem.

Do you have some code for it? Did you write a new test for math.sqrt? Could you please provide a link to it?

May be you want to replicate what I did before we decide to remove this piece of code.

Do you mean remove this code and run tests? Or you have made some work about it and I should take it into consideration too? Could you please provide a link to it or describe it in more details?

@reazulhoque
Copy link

Hi @PokhodenkoSA I wrote a simple test calling math.sqrt, I do not have it currently.

I meant to write similar test calling math.sqrt and make sure removing this code does not have any affect.

@PokhodenkoSA
Copy link
Author

After several discussions with @DrTodd13 and @reazulhoque: this code was introduced not for dppy functionality and could be removed if it will not break tests.

@PokhodenkoSA PokhodenkoSA merged commit 6e54b8f into IntelPython:pydppl Dec 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants