This repository was archived by the owner on Jan 25, 2023. It is now read-only.
Move dppl_config.py to numba-dppy #106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Conclusion:
/CC @diptorupd |
Note: This place introduces optional dependency `numba` -> `numba_dppy`. Right dependency order is `numba` <- `numba_dppy`. `numba_dppy` is required because of implementation of `with context` requires TargetDispatcher.
dppl_config.py contains flag `dppl_present` which indicate that `dpCtl` and devices are available. As `numba-dppy` will depend on `dpCtl` then the check is not necessary. Also checking for available platform and device could be done in `numba-dppy`. It also can raise and exception on import as before. `dppl_present` also renamed to `dppy_present`.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dppl_config.py contains flag
dppl_presentwhich indicate thatdpCtland devices are available.
As
numba-dppywill depend ondpCtlthen the check is not necessary.Also checking for available platform and device could be done in
numba-dppy. It also can raise and exception on import as before.Closes #118