Skip to content
This repository was archived by the owner on Jan 25, 2023. It is now read-only.

Patch for disable emit_environment_object() for dppl context #100

Merged
merged 1 commit into from
Nov 13, 2020

Conversation

PokhodenkoSA
Copy link

Change introduced in 947b407 by @reazulhoque.

@PokhodenkoSA PokhodenkoSA mentioned this pull request Nov 9, 2020
50 tasks
@PokhodenkoSA
Copy link
Author

Try to remove and run checks. @diptorupd faced segfaults some time ago without this modifications.
If tests will pass then it could be removed.

@diptorupd
Copy link

diptorupd commented Nov 13, 2020

Previously, we were running spirv-val on the SPIR-V binary we generated from Numba. The change was added by me to avoid a spirv-val error that is caused because by default Numba passes a global pointer as an argument to the generated function. The reasoning most likely is that a device function cannot access a global pointer in the host address space and thus it should be disallowed.

However, we never pass anything using the global pointer and it is never accessed, so it might be fine just reverting the change. We have turned off spirv-val a while back to get around other issues that are benign but flagged by spirv-val, so reverting the change should not cause a spirv-val error.

If after reverting the change, the tests pass then we should merge.

@PokhodenkoSA If we remove the code in lowering.py please also remove this line in our target.py

context_name = "dppl.jit"

@PokhodenkoSA
Copy link
Author

@PokhodenkoSA If we remove the code in lowering.py please also remove this line in our target.py

context_name = "dppl.jit"

Created for it - IntelPython/numba-dpex#6

@PokhodenkoSA
Copy link
Author

Tested locally - no new failed tests. Will merge it.

@PokhodenkoSA PokhodenkoSA merged commit e086bce into IntelPython:pydppl Nov 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants