Skip to content

Update go version #515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

reazulhoque
Copy link
Contributor

@reazulhoque reazulhoque commented Aug 17, 2021

The latest update in go version is causing license step in CI to fail. This is an attempt to setup a version of go that will not fail to install license using github action.

@oleksandr-pavlyk
Copy link
Contributor

License workflow is green, so all is good.

Copy link
Contributor

@oleksandr-pavlyk oleksandr-pavlyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just out of the curiosity, is there a reason we do not use the latest one?

@reazulhoque
Copy link
Contributor Author

I did not originally set this up. Without the version specified I am not sure which version of GO runs. I got concerned about this as our license workflow is failing for the latest PRs (#493). While looking for a solution someone suggested upgrading to the version proposed solves this issue. Hence I am using that version.

@reazulhoque reazulhoque merged commit ddc1235 into IntelPython:main Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants