All Numba-dppy tests and examples using the @njit decorator should be used with "with_context" #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
50 tasks
|
@vlad-perevezentsev The changes are correct, let's change all the programs that need this change. |
|
@vlad-perevezentsev Please, merge with main. It will fix CI. |
|
@vlad-perevezentsev Do you know what is causing the conflicts? Please let us know when the work is complete and we will start reviewing it. |
PokhodenkoSA
approved these changes
Dec 7, 2020
PokhodenkoSA
suggested changes
Dec 8, 2020
Merged
PokhodenkoSA
reviewed
Dec 9, 2020
numba_dppy/tests/test_vectorize.py
Outdated
| @@ -5,21 +5,24 @@ | |||
| import sys | |||
| import numpy as np | |||
| from numba import njit, vectorize | |||
| import numba_dppy, numba_dppy as dppy | |||
| import numba_dppy | |||
| import numba_dppy as dppl | |||
There was a problem hiding this comment.
Suggested change
| import numba_dppy as dppl | |
| import numba_dppy as dppy |
|
Windows fails possibly because Level0 is also available on CI machine and it is used by default. |
|
@vlad-perevezentsev Please merge main to this PR and please mention the issues this PR is addressing. |
6 tasks
|
Applied comments from @diptorupd from #65 in this commit b34bb51 |
PokhodenkoSA
approved these changes
Dec 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #30
Changed one test for the example.