Skip to content

Update documentation based on gap analysis #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 43 commits into from
Mar 2, 2021
Merged

Update documentation based on gap analysis #181

merged 43 commits into from
Mar 2, 2021

Conversation

PokhodenkoSA
Copy link
Contributor

Closes #145

PokhodenkoSA and others added 12 commits January 21, 2021 12:46
* Add docs and update example
* Use literalinclude
* Example 1
* Example 2
* Example 3
* Limitations
* Extend docs for Debugging
* Improve docs structure
* Added docs
* Added note
* Small fixes
* Add docs for python features
* Fix headers
* Added docs
* Added note
* Added docs and example
* Use autodoc

Co-authored-by: Sergey Pokhodenko <sergey.pokhodenko@intel.com>
* Added docs and examples for memory management
@diptorupd
Copy link
Contributor

@PokhodenkoSA I have started making edits and will be pushing changes to the branch. Please do not merge yet.

@diptorupd
Copy link
Contributor

@reazulhoque @PokhodenkoSA The section under features is totally out of date and mentions MS138 etc. that are irrelevant. Can you comment the whole thing out and remove it from the gh-pages.

@diptorupd
Copy link
Contributor

Also a general comment, let us avoid the term DPPY instead we can use either SYCL-supported or DPC++-supported. E.g. SYCL-supported GPU instead of DPPY GPU.

@PokhodenkoSA
Copy link
Contributor Author

@diptorupd I have added several fixes. Please, see last commits.

@diptorupd
Copy link
Contributor

diptorupd commented Feb 27, 2021

@diptorupd I have added several fixes. Please, see last commits.

I did a full review and have pushed several changes. I tried to polish up what I can, but am stopping for now. I also restructured the organization of the docs. The overall quality of the docs is still very rough, but we have to go with what we have for now and then keep updating it.

Note that there are sections (e.g, the random functions sections) that I have removed as I could not quite fit it with the rest of the text. The files still are left in the repo, do not add them back.

@reazulhoque Add a section under the Programming SYCL Kernels user guide to detail the synchronization functions that we support in numba_dppy.kernel. Also review the whole Programming SYCL Kernels user guide.
What is the state of the NumPy-support docs?

@PokhodenkoSA Polish up the Getting Started user guide with installation, build instructions and dependencies, etc.

@akharche Since the GDB guide was the best written :) I nominate you to proof-read the whole doc once more and edit as needed. Things to look out will be use of DPPY, broken links, non-loading code listings, and any egregious grammar.

Let us plan for a dochatlon sprint for one week to clean up docs for numba-dppy and dpctl before May conda-forge releases.

@PokhodenkoSA
Copy link
Contributor Author

@PokhodenkoSA Polish up the Getting Started user guide with installation, build instructions and dependencies, etc.

Done.

@akharche
Copy link
Contributor

akharche commented Mar 1, 2021

@akharche proof-read the whole doc once more and edit as needed.

Done

@reazulhoque
Copy link
Contributor

Done.

@PokhodenkoSA
Copy link
Contributor Author

I have restored examples broken after cb77307.
And I have updated docs for reductions and device functions with restored examples.

@PokhodenkoSA PokhodenkoSA merged commit 8b83a3d into release0.13 Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gap analysis: Comparing Numba-dpex to Numba.Cuda
5 participants