Skip to content

Numpy.random implementations #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 27 commits into from
Jan 28, 2021
Merged

Numpy.random implementations #141

merged 27 commits into from
Jan 28, 2021

Conversation

reazulhoque
Copy link
Contributor

@reazulhoque reazulhoque commented Jan 11, 2021 •
edited by PokhodenkoSA
Loading

This PR contains the implementation of different np.random.* functions.

TODO:

  • We need to write tests for all cases, we have coverage for some but not for all.

@reazulhoque reazulhoque mentioned this pull request Jan 12, 2021
Closed
@diptorupd diptorupd mentioned this pull request Jan 12, 2021
Closed
@PokhodenkoSA PokhodenkoSA mentioned this pull request Jan 15, 2021
Open
@akharche akharche self-requested a review January 20, 2021 09:39
@reazulhoque reazulhoque mentioned this pull request Jan 21, 2021
Merged
@PokhodenkoSA PokhodenkoSA mentioned this pull request Jan 25, 2021
Closed
PokhodenkoSA
PokhodenkoSA suggested changes Jan 26, 2021
View reviewed changes
Copy link
Contributor

@PokhodenkoSA PokhodenkoSA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think approach is working.
But I think there is a lot of code duplications.

PokhodenkoSA
PokhodenkoSA reviewed Jan 26, 2021
View reviewed changes
PokhodenkoSA
PokhodenkoSA reviewed Jan 26, 2021
View reviewed changes
PokhodenkoSA
PokhodenkoSA reviewed Jan 26, 2021
View reviewed changes
PokhodenkoSA
PokhodenkoSA reviewed Jan 26, 2021
View reviewed changes
@PokhodenkoSA PokhodenkoSA mentioned this pull request Jan 27, 2021
Open
PokhodenkoSA
PokhodenkoSA reviewed Jan 27, 2021
View reviewed changes
@PokhodenkoSA PokhodenkoSA mentioned this pull request Jan 27, 2021
Closed
PokhodenkoSA
PokhodenkoSA approved these changes Jan 27, 2021
View reviewed changes
Copy link
Contributor

@PokhodenkoSA PokhodenkoSA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are several separate tickets. LGTM.

@PokhodenkoSA PokhodenkoSA mentioned this pull request Jan 27, 2021
Closed
@PokhodenkoSA
Copy link
Contributor

Windows CI fails due to validation problems in 3rd party service. Will merge the PR.

@PokhodenkoSA PokhodenkoSA merged commit 59d4166 into IntelPython:main Jan 28, 2021
@1e-to 1e-to mentioned this pull request Feb 1, 2021
Closed
@vlad-perevezentsev vlad-perevezentsev mentioned this pull request Feb 10, 2021
Closed
@vlad-perevezentsev vlad-perevezentsev mentioned this pull request Feb 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PokhodenkoSA PokhodenkoSA PokhodenkoSA approved these changes

@diptorupd diptorupd Awaiting requested review from diptorupd

@akharche akharche Awaiting requested review from akharche

Assignees
No one assigned
Labels
4 - Ready to merge
Projects
None yet
Milestone
0.13.0
Development

Successfully merging this pull request may close these issues.

Write tests for np.random.functions
3 participants
@reazulhoque @PokhodenkoSA @akharche