Fix tests for using pytest #140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 24, 2020 07:35
PokhodenkoSA
suggested changes
Jan 29, 2021
| @@ -61,7 +61,7 @@ def driver(a, jitfunc): | |||
| return b | |||
|
|
|||
|
|
|||
| def test_driver(input_arr, device_ty, jitfunc): | |||
| def case_driver(input_arr, device_ty, jitfunc): | |||
There was a problem hiding this comment.
Suggested change
| def case_driver(input_arr, device_ty, jitfunc): | |
| def check_driver(input_arr, device_ty, jitfunc): |
| dppy = numba.njit(reduction) | ||
| dppy_result = dppy(a) | ||
|
|
||
| ref_result = reduction(a) | ||
|
|
||
| np.testing.assert_array_equal(dppy_result, ref_result) | ||
| self.assertTrue("Failed to lower parfor on DPPY-device" in msg.getvalue()) | ||
| assert "Failed to lower parfor on DPPY-device" in str(w[-1].message) |
There was a problem hiding this comment.
Suggested change
| assert "Failed to lower parfor on DPPY-device" in str(w[-1].message) | |
| self.assertIn("Failed to lower parfor on DPPY-device", str(w[-1].message) |
| @@ -4,6 +4,7 @@ | |||
| import unittest | |||
| from numba.tests.support import captured_stderr | |||
| @@ -5,6 +5,7 @@ | |||
| from numba_dppy.testing import unittest | |||
| from numba.tests.support import captured_stderr | |||
| self.assertTrue( | ||
| "Failed to lower parfor on DPPY-device" in msg_fallback_true.getvalue() | ||
| ) | ||
| assert "Failed to lower parfor on DPPY-device" in str(w[-1].message) |
PokhodenkoSA
suggested changes
Jan 29, 2021
added 2 commits
January 29, 2021 10:16
PokhodenkoSA
approved these changes
Jan 29, 2021
|
Thank you @1e-to for the fixes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #130