-
Notifications
You must be signed in to change notification settings - Fork 33
Improve built-in ops and dpnp universal functions testing #1283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
efe2d6d to
dd1e75f
Compare
|
@ZzEeKkAa Thank you for the comprehensive evaluation. I am replying to some of your questions and comments in the PR description.
Please log separate issues to track the gap.
The matmul operators not being supported is expected. I believe the The
That is a correct assumption. However, we should note a subtle difference. There are various types of expressions that can be lowered to It is a good idea to add similar unit tests for the |
dd1e75f to
b242513
Compare
b242513 to
583f1a1
Compare
|
Let's test kernel in separate PR. |
583f1a1 to
002c153
Compare
002c153 to
6a341d2
Compare
diptorupd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice changes. Making unit testing more comprehensive is always welcome!
…c_testing Improve built-in ops and dpnp universal functions testing 8fdfc1b
Add full coverage on ufuncs and built-in operators. Motivated by #178
It appears that we were not aware that these functions are not supported:
We also does not support (may be we need proper input data):
matmuloperator (a @ b)imatmuloperator (a @= b)not_operator (not a) (because numpy does not support it)Open question:
Checklist: