Skip to content

Spokhode/dparray tests #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Dec 15, 2020
Merged

Spokhode/dparray tests #118

merged 6 commits into from
Dec 15, 2020

Conversation

PokhodenkoSA
Copy link
Contributor

Convert examples style tests to unittest.

@PokhodenkoSA PokhodenkoSA merged commit f4333dd into spokhode/dparray Dec 15, 2020
1e-to
1e-to reviewed Dec 15, 2020
View reviewed changes
numba_dppy/tests/test_usmarray.py Outdated

from numba_dppy.testing import DPPYTestCase
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't use DPPYTestCase anymore.
Use unittest.TestCase instead

DrTodd13
DrTodd13 reviewed Dec 15, 2020
View reviewed changes
Copy link
Contributor

@DrTodd13 DrTodd13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks fine with my previous comment that the USM to numpy implicit conversion test should be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DrTodd13 DrTodd13 DrTodd13 left review comments

@1e-to 1e-to 1e-to left review comments

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev

Assignees

@PokhodenkoSA PokhodenkoSA

Labels
tests Related to test suite or test run infrastructure
Projects
None yet
Milestone
MS141 (0.12.0)
Development

Successfully merging this pull request may close these issues.
3 participants
@PokhodenkoSA @DrTodd13 @1e-to