Repository navigation
Rewrite native FFT benchmarks - #6
Merged
Merged
Conversation
| CFLAGS = -m64 -fPIC -fp-model strict -O3 -g -fomit-frame-pointer \ | ||
| -DNDEBUG -qopenmp -xSSE4.2 -axCORE-AVX2,COMMON-AVX512 \ | ||
| -lmkl_rt | ||
| -lmkl_rt -DDEBUG -Wall -pedantic |
Contributor
There was a problem hiding this comment.
What is the point of having -DDEBUG alongside -DNDEBUG ?
Contributor
Author
There was a problem hiding this comment.
I had written some debug messages in an earlier revision enabled with -DDEBUG, but they've been since removed, so this flag is now useless. I went ahead and removed it - thanks!
Contributor
|
Help seems to suggest that option |
Contributor
Author
|
Short options |
oleksandr-pavlyk
approved these changes
Jan 10, 2020
oleksandr-pavlyk
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Thanks @bibikar
Contributor
|
👍 |
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@oleksandr-pavlyk
This PR includes a complete rewrite of native FFT benchmarks using MKL DFTI:
getopt_long) instead of envCopying superfluous harmonics for conjugate-even outputs produced by the FFT for real inputs as is done in mkl_fft is not yet implemented, but using the
--rfftargument allows skipping that step for now. I don't think our native benchmarks have ever supported FFTs of real inputs with full outputs.The benchmark still works on Windows, but only short options are supported there.