Skip to content

out-of-place native FFT: move buffer alloc inside timing - #5

Merged
oleksandr-pavlyk merged 3 commits into
IntelPython:masterfrom
bibikar:feature/time_alloc
Jul 24, 2019
Merged

oleksandr-pavlyk merged 3 commits into
IntelPython:masterfrom
bibikar:feature/time_alloc

Conversation

@bibikar

@bibikar bibikar commented Jul 24, 2019

Copy link
Copy Markdown
Contributor

This matches our Python behavior for these benchmarks.

@oleksandr-pavlyk

Copy link
Copy Markdown
Contributor

Overall the change is good. Thanks!

However, removal of #incude print_buf.inc means that even for small inputs the computed Fourier harmonics are not going to be printed out.

If this is unintended, we should put the include in the loop, like:

     if (s == 0 && it == -1) {
           # include print_buf.inc
     } 

@oleksandr-pavlyk oleksandr-pavlyk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you!

@oleksandr-pavlyk
oleksandr-pavlyk merged commit 5fd25e9 into IntelPython:master Jul 24, 2019
@bibikar
bibikar deleted the feature/time_alloc branch July 24, 2019 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants