Repository navigation
Sync third-party tests with recent upstream changes - #3092
Open
antonwolfy wants to merge 7 commits into
Open
antonwolfy wants to merge 7 commits into
antonwolfy wants to merge 7 commits into
Conversation
Add new tests for ufunc, reduction, elementwise kernel, copyto and concatenate argument handling. Tests relying on unsupported features (ufunc interface, CUDA array interface, ReductionKernel, ElementwiseKernel) are skipped; expected error messages are adapted to dpnp where only the wording differs.
Skip the argmax/argmin int32 overflow tests when the large array cannot be allocated, rework the huge FFT allocation test to check free memory upfront and clean up afterwards, and raise the timeout for the jitify tests.
Add the thread_unsafe_on_windows helper and keep its use on test_conversion_device_to_cpu commented out, since the thread_unsafe marker is not registered in dpnp and the test is already skipped.
antonwolfy
requested review from
ndgrigorian and
vlad-perevezentsev
as code owners
October 10, 2026 13:20
Contributor
|
View rendered docs @ https://intelpython.github.io/dpnp/pull/3092/index.html |
Contributor
|
Array API standard conformance tests for dpnp=0.21.0dev13=np2py314h8d9cdd5_12 ran successfully. |
Collaborator
| from __future__ import annotations | ||
|
|
||
| import ctypes | ||
| import sys |
Contributor
There was a problem hiding this comment.
test_take_negative_index_at_int32_size_boundary in dpnp/tests/third_party/cupy/core_tests/test_ndarray_adv_indexing.py is missing
https://github.com/cupy/cupy/blob/main/tests/cupy_tests/core_tests/test_ndarray_adv_indexing.py#L725
| ] | ||
|
|
||
|
|
||
| def thread_unsafe_on_windows(func): |
Contributor
There was a problem hiding this comment.
This function is not used
Does it make sense to comment it out?
Contributor
Author
There was a problem hiding this comment.
That would increase the diff, while keeping it has no drawback.
pytest-timeout is not part of the dpnp test dependencies.
Parametrize test_quantile_out over C and F output order and check the supplied out array, and add tests for singleton non-reduced dimensions and NaN in the next slice. TestQuantileMethods remains skipped since dpnp.quantile() is not implemented yet.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR syncs the third-party tests with recent upstream test changes. Only test files are changed.