Skip to content

Makes tests with floor_divide more stable on PVC #2459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 20, 2025

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented May 19, 2025

TestFloorDivideRemainder::test_basic test generates the same values for both input array.
The PR proposes to change values for divisor input array and to make them different from dividend input array. That should makes test more stable with float32 data type.
Currently it might fail on PVC with LTS driver for case with floor_divide function.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

@antonwolfy antonwolfy self-assigned this May 19, 2025
Copy link
Contributor

github-actions bot commented May 19, 2025

View rendered docs @ https://intelpython.github.io/dpnp/index.html

Copy link
Contributor

github-actions bot commented May 19, 2025

Array API standard conformance tests for dpnp=0.18.0dev3=py312he4f9c94_6 ran successfully.
Passed: 1231
Failed: 0
Skipped: 9

@coveralls
Copy link
Collaborator

coveralls commented May 19, 2025

Coverage Status

coverage: 71.757%. remained the same
when pulling 5534b5b on resolve-test-filaure-on-pvc-in-floor_divide
into 56ccf86 on master.

@antonwolfy antonwolfy marked this pull request as ready for review May 19, 2025 20:35
@antonwolfy antonwolfy merged commit 23d7281 into master May 20, 2025
64 of 68 checks passed
@antonwolfy antonwolfy deleted the resolve-test-filaure-on-pvc-in-floor_divide branch May 20, 2025 09:19
github-actions bot added a commit that referenced this pull request May 20, 2025
`TestFloorDivideRemainder::test_basic` test generates the same values
for both input array.
The PR proposes to change values for divisor input array and to make
them different from dividend input array. That should makes test more
stable with `float32` data type.
Currently it might fail on PVC with LTS driver for case with
`floor_divide` function. 23d7281
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants