Skip to content

Fix issue gh-2311 #2314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 17, 2025
Merged

Fix issue gh-2311 #2314

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d0edfe7
Allocate C order array for q in dpnp.linalg.qr()
vlad-perevezentsev Feb 13, 2025
7b2e77b
Add test cases when n=1
vlad-perevezentsev Feb 13, 2025
209880e
Merge master into fix_qr_issue
vlad-perevezentsev Feb 13, 2025
639526c
Merge master into fix_qr_issue
vlad-perevezentsev Feb 14, 2025
55d2679
Merge master into fix_qr_issue
vlad-perevezentsev Feb 14, 2025
33e7ab9
Merge master into fix_qr_issue
vlad-perevezentsev Feb 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions dpnp/linalg/dpnp_utils_linalg.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -449,13 +449,15 @@ def _batched_qr(a, mode="reduced"):
a_t,
shape=(batch_size, m, m),
dtype=res_type,
order="C",
)
else:
mc = k
q = dpnp.empty_like(
a_t,
shape=(batch_size, n, m),
dtype=res_type,
order="C",
)

# use DPCTL tensor function to fill the matrix array `q[..., :n, :]`
Expand Down Expand Up @@ -2532,13 +2534,15 @@ def dpnp_qr(a, mode="reduced"):
a_t,
shape=(m, m),
dtype=res_type,
order="C",
)
else:
mc = k
q = dpnp.empty_like(
a_t,
shape=(n, m),
dtype=res_type,
order="C",
)

# use DPCTL tensor function to fill the matrix array `q[:n]`
Expand Down
14 changes: 13 additions & 1 deletion dpnp/tests/test_linalg.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2372,12 +2372,24 @@ class TestQr:
@pytest.mark.parametrize("dtype", get_all_dtypes(no_bool=True))
@pytest.mark.parametrize(
"shape",
[(2, 2), (3, 4), (5, 3), (16, 16), (2, 2, 2), (2, 4, 2), (2, 2, 4)],
[
(2, 1),
(2, 2),
(3, 4),
(5, 3),
(16, 16),
(3, 3, 1),
(2, 2, 2),
(2, 4, 2),
(2, 2, 4),
],
ids=[
"(2, 1)",
"(2, 2)",
"(3, 4)",
"(5, 3)",
"(16, 16)",
"(3, 3, 1)",
"(2, 2, 2)",
"(2, 4, 2)",
"(2, 2, 4)",
Expand Down
Loading