Skip to content

implement dpnp.insert #2151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Nov 8, 2024
Merged

implement dpnp.insert #2151

merged 10 commits into from
Nov 8, 2024

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented Nov 5, 2024

In this PR, dpnp.insert is implemented.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vtavana vtavana self-assigned this Nov 5, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 5, 2024 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@vtavana vtavana marked this pull request as ready for review November 6, 2024 02:23
antonwolfy
antonwolfy reviewed Nov 6, 2024
View reviewed changes
antonwolfy
antonwolfy approved these changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vtavana . I left only one minor comments, but in overall LGTM!

@antonwolfy antonwolfy merged commit d06277f into master Nov 8, 2024
46 checks passed
@antonwolfy antonwolfy deleted the impl_insert branch November 8, 2024 10:38
github-actions bot added a commit that referenced this pull request Nov 8, 2024
@github-actions
implement dpnp.insert (#2151)
904d04f 
* implement dpnp.insert

* fix pre-commit issue

* improve coverage

* address comments

* revert changing empty to empty_like

* use dpnp.is_supported_array_type

---------

Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com> d06277f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@npolina4 npolina4 Awaiting requested review from npolina4

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

Assignees

@vtavana vtavana

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vtavana @antonwolfy