Add implementation of dpnp.sinc function
#2133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
antonwolfy
requested review from
npolina4,
vlad-perevezentsev and
vtavana
as code owners
vtavana
reviewed
Oct 31, 2024
Co-authored-by: vtavana <120411540+vtavana@users.noreply.github.com>
vtavana
reviewed
Nov 1, 2024
vtavana
approved these changes
Nov 4, 2024
github-actions bot
added a commit
that referenced
this pull request
Nov 4, 2024
* Add _sinc to ufunc extension * Add dpnp.sinc function to the interface * Add third party tests * Add complex type handling * Mute tests for dono.i0 * Add CFD tests * Add more tests to cover different use cases * Add a proper handling of corner cases * Update dpnp/dpnp_iface_mathematical.py Co-authored-by: vtavana <120411540+vtavana@users.noreply.github.com> * Removed limitation block * Use dedicated DPNPSinc class for dpnp.sinc implementation --------- Co-authored-by: vtavana <120411540+vtavana@users.noreply.github.com> 5a39d91
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR proposes to add implementation of
dpnp.sincfunction.The new dedicated
_sincfunction is added to_ufunc_implpybind11 extension.All the required tests are implemented to cover the new function.