Skip to content

Add implementation of dpnp.spacing function #2125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Nov 1, 2024
Merged

Add implementation of dpnp.spacing function #2125

merged 11 commits into from
Nov 1, 2024

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Oct 25, 2024 •
edited
Loading

The PR proposes to add implementation of dpnp.spacing function.

The new dedicated _spacing function is added to _ufunc_impl pybind11 extension.
All the required tests are implemented to cover the new function.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Oct 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 30, 2024 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

vtavana
vtavana approved these changes Oct 31, 2024
View reviewed changes
Copy link
Collaborator

@vtavana vtavana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @antonwolfy!

antonwolfy and others added 2 commits November 1, 2024 01:26
@antonwolfy @vtavana
Update dpnp/dpnp_iface_mathematical.py
12a0695 
Co-authored-by: vtavana <120411540+vtavana@users.noreply.github.com>
@antonwolfy
Merge branch 'master' into impl-spacing
4de9338
@antonwolfy antonwolfy merged commit 16d6ea1 into master Nov 1, 2024
43 of 46 checks passed
@antonwolfy antonwolfy deleted the impl-spacing branch November 1, 2024 10:37
github-actions bot added a commit that referenced this pull request Nov 1, 2024
@github-actions
Add implementation of dpnp.spacing function (#2125)
53bf874 
* Add _spacing to ufunc extension

* Add implemntation of dpnp.spacing

* Unmute umath tests for dpnp.spacing

* Add CFD tests

* Add more tests to cover different use cases

* Add dedicated sign handling for float16 dtype

* Fix typo in the comment

* Updated comment in test

* Update dpnp/dpnp_iface_mathematical.py

Co-authored-by: vtavana <120411540+vtavana@users.noreply.github.com>

---------

Co-authored-by: vtavana <120411540+vtavana@users.noreply.github.com> 16d6ea1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtavana vtavana vtavana approved these changes

@npolina4 npolina4 Awaiting requested review from npolina4

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

Assignees

@antonwolfy antonwolfy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antonwolfy @vtavana