Skip to content

Backport gh-2063 #2068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 20, 2024
Merged

Backport gh-2063 #2068

merged 1 commit into from
Sep 20, 2024

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented Sep 19, 2024

This PR backports of #2063 from development branch to maintenance/0.16.x.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy @vtavana
Resolve crash identified in backend implementation of dpnp.choose (#…
22b281a 
…2063)

* Add memory copy to device memory

* Keep extra memcopy only for the result array

* Add missing memory copy from host to device memory

* Applied pre-commit formatting

* Updated changelog

* Add empty line in changelog

* Correct the description of issue in changelog
@vtavana vtavana self-assigned this Sep 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 19, 2024 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@antonwolfy antonwolfy merged commit e43b050 into maintenance/0.16.x Sep 20, 2024
25 of 46 checks passed
@antonwolfy antonwolfy deleted the backport-gh-2063 branch September 20, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy Awaiting requested review from antonwolfy antonwolfy is a code owner

@npolina4 npolina4 Awaiting requested review from npolina4

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

Assignees

@vtavana vtavana

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vtavana @antonwolfy