Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementation of dpnp.fft.fft2, dpnp.fft.ifft2, dpnp.fft.fftn, dpnp.fft.ifftn #1961

Merged
merged 17 commits into from
Aug 12, 2024
Merged

Implementation of dpnp.fft.fft2, dpnp.fft.ifft2, dpnp.fft.fftn, dpnp.fft.ifftn #1961

merged 17 commits into from
Aug 12, 2024

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented Aug 1, 2024

In this PR, dpnp.fft.fft2, dpnp.fft.ifft2, dpnp.fft.fftn, dpnp.fft.ifftn are implemented.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vtavana vtavana self-assigned this Aug 1, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 1, 2024 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

antonwolfy
antonwolfy reviewed Aug 6, 2024
View reviewed changes
dpnp/fft/dpnp_iface_fft.py Outdated Show resolved Hide resolved
dpnp/fft/dpnp_iface_fft.py Outdated Show resolved Hide resolved
dpnp/fft/dpnp_iface_fft.py Outdated Show resolved Hide resolved
dpnp/fft/dpnp_iface_fft.py Outdated Show resolved Hide resolved
dpnp/fft/dpnp_iface_fft.py Show resolved Hide resolved
dpnp/fft/dpnp_utils_fft.py Show resolved Hide resolved
dpnp/fft/dpnp_utils_fft.py Outdated Show resolved Hide resolved
dpnp/fft/dpnp_utils_fft.py Outdated Show resolved Hide resolved
dpnp/fft/dpnp_utils_fft.py Outdated Show resolved Hide resolved
dpnp/fft/dpnp_utils_fft.py Outdated Show resolved Hide resolved
antonwolfy
antonwolfy previously approved these changes Aug 8, 2024
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No more comments from me, thank you @vtavana

@vtavana vtavana requested a review from antonwolfy August 9, 2024 19:41
@vtavana vtavana dismissed antonwolfy’s stale review August 9, 2024 19:42

new changes were added

antonwolfy
antonwolfy approved these changes Aug 12, 2024
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vtavana , LGTM
I have only one minor comment/question.

tests/third_party/cupy/fft_tests/test_fft.py Outdated Show resolved Hide resolved
@vtavana vtavana merged commit 4b3b324 into master Aug 12, 2024
32 of 45 checks passed
@vtavana vtavana deleted the fftn branch August 12, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

@npolina4 npolina4 Awaiting requested review from npolina4 npolina4 is a code owner

Assignees

@vtavana vtavana

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vtavana @antonwolfy