Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve a possible race condition in dpnp.inv() implemenetation #1940

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Jul 22, 2024

The PR proposes to implement a fix preventing possible race condition inside dpnp.inv function.

It assumes _gesv call depends on both copy event and event produced above dpnp.eye call and so it is mandatory to pass depends=_manager.submitted_events there.

The issue was caught during the analysis of failed tests in GitHub actions. No need to implement any dedicated test to cover that use case.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

Copy link
Contributor

github-actions bot commented Jul 22, 2024

View rendered docs @ https://intelpython.github.io/dpnp/index.html

Copy link
Collaborator

@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thank you @antonwolfy for finding and fixing it

@antonwolfy antonwolfy merged commit 08928bf into master Jul 22, 2024
32 of 45 checks passed
@antonwolfy antonwolfy deleted the fix-race-condition-in-dpnp-inv branch July 22, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants