Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement dpnp.fft.rfft and dpnp.fft.irfft #1928

Merged
merged 11 commits into from
Jul 30, 2024
Merged

implement dpnp.fft.rfft and dpnp.fft.irfft #1928

merged 11 commits into from
Jul 30, 2024

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented Jul 15, 2024

In this PR, dpnp.fft.rfft and dpnp.fft.irfft are implemented using pybind11 extension of call back on MKL DFT library.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vtavana vtavana self-assigned this Jul 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 15, 2024 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@vtavana vtavana marked this pull request as ready for review July 15, 2024 19:18
antonwolfy
antonwolfy reviewed Jul 22, 2024
View reviewed changes
dpnp/backend/extensions/fft/fft_utils.hpp Show resolved Hide resolved
dpnp/backend/include/dpnp_iface_fptr.hpp Show resolved Hide resolved
dpnp/backend/kernels/dpnp_krnl_fft.cpp Show resolved Hide resolved
dpnp/fft/dpnp_iface_fft.py Outdated Show resolved Hide resolved
dpnp/fft/dpnp_utils_fft.py Outdated Show resolved Hide resolved
dpnp/fft/dpnp_utils_fft.py Outdated Show resolved Hide resolved
dpnp/fft/dpnp_utils_fft.py Show resolved Hide resolved
dpnp/fft/dpnp_utils_fft.py Show resolved Hide resolved
dpnp/fft/dpnp_utils_fft.py Outdated Show resolved Hide resolved
dpnp/fft/dpnp_utils_fft.py Outdated Show resolved Hide resolved
antonwolfy
antonwolfy approved these changes Jul 29, 2024
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vtavana

@vtavana vtavana merged commit 4498f86 into master Jul 30, 2024
38 of 45 checks passed
@vtavana vtavana deleted the rfft branch July 30, 2024 00:07
github-actions bot added a commit that referenced this pull request Jul 30, 2024
@github-actions
implement dpnp.fft.rfft and dpnp.fft.irfft (#1928)
ccb37e3 
* implement rfft and irfft

* update tests

* remove redundant test

* clean-up

* separate backend structures

* address comments

* mute tests on gpu with fp64 support 4498f86
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

@npolina4 npolina4 Awaiting requested review from npolina4 npolina4 is a code owner

Assignees

@vtavana vtavana

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vtavana @antonwolfy