Skip to content

Adopt linalg functions from LAPACK extension to asynchronous dpctl execution #1922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 15, 2024
Merged

Adopt linalg functions from LAPACK extension to asynchronous dpctl execution #1922

merged 6 commits into from
Jul 15, 2024
+212 −194

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Jul 12, 2024 •
edited
Loading

The PR continues work started in #1897.
It propose to update all dpnp functions from linear algebra routine which use LAPACK extension and to align them with asynchronous dpctl execution.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Jul 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 12, 2024 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@antonwolfy antonwolfy marked this pull request as ready for review July 12, 2024 17:39
Base automatically changed from add-einsum-utils to master July 13, 2024 10:48
vlad-perevezentsev
vlad-perevezentsev reviewed Jul 15, 2024
View reviewed changes
vlad-perevezentsev
vlad-perevezentsev approved these changes Jul 15, 2024
View reviewed changes
Copy link
Collaborator

@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thank you @antonwolfy

@antonwolfy antonwolfy merged commit fb50c2e into master Jul 15, 2024
@antonwolfy antonwolfy deleted the adopt-lapack-to-async-dpctl-execution branch July 15, 2024 11:48
github-actions bot added a commit that referenced this pull request Jul 15, 2024
@github-actions
Adopt linalg functions from LAPACK extension to asynchronous dpctl ex…
e49ed5f 
…ecution (#1922)

* Update LinAlg functions from BLAS routine

* Decouple einsum utils function to separate file

* Update LinAlg functions from LAPACK routine

* Removed batch_call from dpnp_svd() fb50c2e
@antonwolfy antonwolfy mentioned this pull request Jul 16, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vlad-perevezentsev vlad-perevezentsev vlad-perevezentsev approved these changes

@npolina4 npolina4 Awaiting requested review from npolina4

@vtavana vtavana Awaiting requested review from vtavana vtavana is a code owner

Assignees

@antonwolfy antonwolfy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antonwolfy @vlad-perevezentsev