Skip to content

Implement dpnp.isreal, dpnp.isrealobj, dpnp.iscomplex, dpnp.iscomplexobj. #1916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jul 13, 2024
Merged

Implement dpnp.isreal, dpnp.isrealobj, dpnp.iscomplex, dpnp.iscomplexobj. #1916

merged 8 commits into from
Jul 13, 2024
+349 −20

Conversation

npolina4
Copy link
Contributor

@npolina4 npolina4 commented Jul 9, 2024

Implement dpnp.isreal, dpnp.isrealobj, dpnp.iscomplex, dpnp.iscomplexobj.
Added tests.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 9, 2024 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

vtavana
vtavana reviewed Jul 9, 2024
View reviewed changes
antonwolfy
antonwolfy reviewed Jul 10, 2024
View reviewed changes
@npolina4 npolina4 changed the title Implement dpnp.isreal, dpnp.iscomplex Implement dpnp.isreal, dpnp.isrealobj, dpnp.iscomplex, dpnp.iscomplexobj. Jul 10, 2024
antonwolfy
antonwolfy reviewed Jul 11, 2024
View reviewed changes
antonwolfy
antonwolfy reviewed Jul 12, 2024
View reviewed changes
antonwolfy
antonwolfy approved these changes Jul 13, 2024
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @npolina4, no more comments from me.

@vtavana vtavana merged commit 0590a92 into master Jul 13, 2024
@vtavana vtavana deleted the impl_isreal branch July 13, 2024 14:56
github-actions bot added a commit that referenced this pull request Jul 13, 2024
@github-actions
Implement dpnp.isreal, dpnp.isrealobj, dpnp.iscomplex, dpnp.iscomplex…
a1965a2 
…obj. (#1916)

* Implement dpnp.isreal, dpnp.iscomplex

* Applied review comments

* Applied review comments

* Simplified isreal and iscomplex tests

---------

Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com> 0590a92
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtavana vtavana vtavana left review comments

@antonwolfy antonwolfy antonwolfy approved these changes

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@npolina4 @antonwolfy @vtavana