-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up legacy array creation and manipulation implementation from the backend #1903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
antonwolfy
reviewed
Jun 28, 2024
npolina4
changed the title
Clean up legacy array creation implementation from the backend
Clean up legacy array creation and manipulation implementation from the backend
Jul 1, 2024
antonwolfy
reviewed
Jul 3, 2024
antonwolfy
reviewed
Jul 3, 2024
antonwolfy
approved these changes
Jul 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @npolina4
github-actions bot
added a commit
that referenced
this pull request
Jul 3, 2024
…he backend (#1903) * Clean up legacy element-wise implementation from the backend * return legacy copy implementation for partition function * Apply comments * Fix pre-commit * Fix pre-commit * Clean up legacy array creation implementation from the backend * Clean-up MACRO_2ARG_2TYPES_LOGIC_OP. Clean-up /backend/include * Removed backend/examples for removed functions * address comments * address comments --------- Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com> Co-authored-by: Anton Volkov <antonwolfy@gmail.com> 2fff1f1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaned up legacy array creation and array manipulation implementation from the backend for speed up build and improve code coverage.
Cleaned up legacy diag_indices implementation from the backend.
Changes was tested with numda-dpex component.