Skip to content

implement dpnp.fft.fftfreq and dpnp.fft.rfftfreq #1898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 14, 2024
Merged

implement dpnp.fft.fftfreq and dpnp.fft.rfftfreq #1898

merged 7 commits into from
Jul 14, 2024

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented Jun 26, 2024

In this PR, dpnp.fft.fftfreq and dpnp.fft.rfftfreq are implemented with support for device, sycl_queue, usm_type keywords to control memory allocation per compute follows data programming model.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vtavana vtavana self-assigned this Jun 26, 2024
@vtavana vtavana marked this pull request as ready for review June 26, 2024 14:33
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 26, 2024 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

antonwolfy
antonwolfy reviewed Jul 13, 2024
View reviewed changes
antonwolfy
antonwolfy approved these changes Jul 13, 2024
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vtavana

@vtavana vtavana merged commit f9cbc62 into master Jul 14, 2024
@vtavana vtavana deleted the fftfreq branch July 14, 2024 14:02
github-actions bot added a commit that referenced this pull request Jul 14, 2024
@github-actions
implement dpnp.fft.fftfreq and dpnp.fft.rfftfreq (#1898)
b9eebe7 
* implement fftfreq

* fix pre-commit

* Apply suggestions from code review

Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com>

* update cupy tests

---------

Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com> f9cbc62
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

@npolina4 npolina4 Awaiting requested review from npolina4

Assignees

@vtavana vtavana

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vtavana @antonwolfy