Rework implementation of dpnp.fmod function
#1883
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…solve link issues
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
vlad-perevezentsev
approved these changes
Jun 25, 2024
github-actions bot
added a commit
that referenced
this pull request
Jun 26, 2024
* Preparation to reuse common dpctl f/w for VM functions * PoC to decouple abs implementation to separate source file * Reuse typedef for function poiter from dpctl.tensor * Define populating vectors by a separate macro * Move implementation of utility functions from headers to source to resolve link issues * Separated implementation of acos function * Separated implementation of acosh function * Use function to simplify strides from dpctl tensor headers * PoC to decouple add implementation to separate source file * Separated implementation of asin function * Separated implementation of asinh function * Separated implementation of atan, atan2, atanh functions * Resolve issue with calling MKL function for undefined types * Separated implementation of cbrt, ceil, conj, cos and cosh functions * Separated implementation of div, exp, exp2, expm1, floor and hypot functions * Separated implementation of ln, log1p, log2 and log10 functions * Separated implementation of mul, pow, rint, sin and sinh functions * Separated implementation of sqr, sqrt, sub, tan, tanh and trunc functions * Removed unused header with types matrix * Remove unused functions * Use passing by reference in unary and binary funcs * Implement dpnp.fabs function * Create an instance of DPNPUnaryFunc for fabs * Enable and add relating tests * Decouple populate logic to a macro * Resolve compilation failure on Win * Implement dpnp.fmod function * Add vector implementation and dedicated kernel for boolean inputs * Update python implementation part * Add MKL function to the VM extension * Add tests * Add a link to gh issue in arithmetic tests * Suppress divide warning * Resolve compilation warning * Updated docstring description of inputs per review comment 73ace12
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR proposes to rework implementation of
dpnp.fmodfunction which is quite limited now.There is new VM function is added to use
fmodfrom OneMKL library where it's possible.Also the PR adds new binary universal function
_fmodto _ufunc_impl pybind11 extension which leverages on dpctl f/w.The all affected tests are updated to cover different use cases. The scope of impacted third party tests is aligned with the latest content.