Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement dpnp.gradient function #1859

Merged
merged 6 commits into from
May 31, 2024
Merged

Implement dpnp.gradient function #1859

merged 6 commits into from
May 31, 2024

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented May 28, 2024 •
edited
Loading

The PR implements dpnp.gradient function through existing calls and adds support of all keyword arguments which available in numpy.
The affected test scope is unmuted and extended to cover more use cases.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this May 28, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 29, 2024 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@antonwolfy antonwolfy marked this pull request as ready for review May 29, 2024 10:49
vtavana
vtavana reviewed May 30, 2024
View reviewed changes
dpnp/dpnp_iface_mathematical.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_mathematical.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_mathematical.py Show resolved Hide resolved
antonwolfy and others added 2 commits May 30, 2024 07:39
@antonwolfy @vtavana
Update dpnp/dpnp_iface_mathematical.py
75f6bfb 
Co-authored-by: vtavana <120411540+vtavana@users.noreply.github.com>
@antonwolfy @vtavana
Update dpnp/dpnp_iface_mathematical.py
ce82ae9 
Co-authored-by: vtavana <120411540+vtavana@users.noreply.github.com>
vtavana
vtavana approved these changes May 30, 2024
View reviewed changes
Copy link
Collaborator

@vtavana vtavana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @antonwolfy!

@antonwolfy antonwolfy merged commit 841664c into master May 31, 2024
56 checks passed
@antonwolfy antonwolfy deleted the impl_gradient branch May 31, 2024 09:34
github-actions bot added a commit that referenced this pull request May 31, 2024
@github-actions
Implement dpnp.gradient function (#1859)
b552bc9 
* Implement dpnp.gradient function

* Resolve pre-commit issues

* Update dpnp/dpnp_iface_mathematical.py

Co-authored-by: vtavana <120411540+vtavana@users.noreply.github.com>

* Update dpnp/dpnp_iface_mathematical.py

Co-authored-by: vtavana <120411540+vtavana@users.noreply.github.com>

---------

Co-authored-by: vtavana <120411540+vtavana@users.noreply.github.com> 841664c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vlad-perevezentsev vlad-perevezentsev vlad-perevezentsev left review comments

@vtavana vtavana vtavana approved these changes

@npolina4 npolina4 Awaiting requested review from npolina4 npolina4 is a code owner

Assignees

@antonwolfy antonwolfy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@antonwolfy @vlad-perevezentsev @vtavana