Skip to content

Conversation

npolina4
Copy link
Contributor

dpnp.flatten does not work for not default queue because sycl_device and sycl_queue cannot be provide together.
This is fixed by this PR

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

Copy link
Contributor

github-actions bot commented May 14, 2024

View rendered docs @ https://intelpython.github.io/dpnp/index.html

npolina4 and others added 3 commits May 14, 2024 13:40
Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com>
Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com>
Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com>
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @npolina4

@antonwolfy antonwolfy merged commit d0d26b4 into master May 17, 2024
@antonwolfy antonwolfy deleted the fix_flatten branch May 17, 2024 11:04
github-actions bot added a commit that referenced this pull request May 17, 2024
* Fix dpnp.flatten

* Fix docs

* Update dpnp/dpnp_array.py

Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com>

* Update dpnp/dpnp_array.py

Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com>

* Update dpnp/dpnp_array.py

Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com>

---------

Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com> d0d26b4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants