Improve performance for dpnp.diag() #1822
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
antonwolfy
reviewed
May 13, 2024
antonwolfy
approved these changes
May 13, 2024
There was a problem hiding this comment.
Thank you @vlad-perevezentsev for implementing so noticeable improvement.
github-actions bot
added a commit
that referenced
this pull request
May 13, 2024
* Update dpnp.diag to improve perfomance * Use dpnp.zero_like() instead of dpnp.zeros() * Update doctrings for dpnp.diagflat/eye/identity * Update cupy test_matrix.py 4ef2157
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR suggests to update
dpnp.diag()implementation with a reuse ofdpnp.diagonal()and return a read/write view instead of copy if the input array is an instance of {dpnp.ndarray,usm_ndarray} for the default case (device,usm_type,sycl_queueareNone).These changes greatly improve performance compared to the old implementation