Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed an issue in dpnp.random.vonmises function identified by running tests scope on PVC #1799

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Apr 23, 2024

Function dpnp.isnan doesn't support scalar input and raises TypeError exception. But the call with scalar input is using by implementation of dpnp.random.vonmises function.

The PR proposes to always call numpy.isnan there instead, because it's secured that kappa is a scalar by a prior check in the code.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Apr 23, 2024
Copy link
Contributor

github-actions bot commented Apr 23, 2024

View rendered docs @ https://intelpython.github.io/dpnp/pull//index.html

Copy link
Collaborator

@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @antonwolfy

@antonwolfy antonwolfy merged commit d19fbca into master Apr 23, 2024
51 of 56 checks passed
@antonwolfy antonwolfy deleted the use-numpy-isnan-for-scalar-input branch April 23, 2024 10:19
github-actions bot added a commit to antonwolfy/dpnp that referenced this pull request Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants