Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Leverage dpnp.cumsum through dpctl.tensor implementation #1772

Merged
merged 8 commits into from
Apr 9, 2024
Merged

Leverage dpnp.cumsum through dpctl.tensor implementation #1772

merged 8 commits into from
Apr 9, 2024

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Apr 2, 2024 •
edited
Loading

The PR is about to implement dpnp.cumsum through leveraging on dpctl implementation.

Note dpnp_cumsum is left in the backend code, because it is used by dpnp_nancumsum function also.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Apr 2, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 3, 2024 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@antonwolfy antonwolfy force-pushed the implement-cumsum branch 2 times, most recently from 68beec9 to d85f757 Compare April 3, 2024 13:27
@antonwolfy antonwolfy marked this pull request as ready for review April 4, 2024 12:21
vtavana
vtavana approved these changes Apr 9, 2024
View reviewed changes
Copy link
Collaborator

@vtavana vtavana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @antonwolfy!

@antonwolfy antonwolfy merged commit 9705a51 into master Apr 9, 2024
45 checks passed
@antonwolfy antonwolfy deleted the implement-cumsum branch April 9, 2024 15:32
github-actions bot added a commit to antonwolfy/dpnp that referenced this pull request Apr 9, 2024
@github-actions
Leverage dpnp.cumsum through dpctl.tensor implementation (IntelPyth…
2752847 
…on#1772)

* Implement dpnp.cumsum through dpctl.tensor

* Aligned dpnp.ndarray docs

* Fixed tests for cumprod on Windows

* Enabled missing test_sum_axis2_float16 test

* Added tests

* Align return logic with dpnp.sum()

* Used a helper function to assert arrays for tests of SYCL queue

* Mute a test for dpnp.cumprod on Windows until proper impl is done 9705a51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtavana vtavana vtavana approved these changes

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

@npolina4 npolina4 Awaiting requested review from npolina4 npolina4 is a code owner

Assignees

@antonwolfy antonwolfy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antonwolfy @vtavana