Skip to content

update dpnp.inner implementation #1726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 22, 2024
Merged

update dpnp.inner implementation #1726

merged 4 commits into from
Feb 22, 2024

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented Feb 21, 2024

In this PR, dpnp.inner is updated using existing functions in dpnp.

dpnp.cross is updated to raise an error when both inputs are boolean.

dpnp.tensordot is updated to directly call dpnp.multiply when one of the inputs is scalar or 0-dimensional.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vtavana vtavana self-assigned this Feb 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 21, 2024 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/pull//index.html

@vtavana vtavana marked this pull request as ready for review February 21, 2024 15:01
@vtavana vtavana requested a review from antonwolfy February 21, 2024 15:01
antonwolfy
antonwolfy reviewed Feb 21, 2024
View reviewed changes
vtavana
vtavana commented Feb 22, 2024
View reviewed changes
antonwolfy
antonwolfy approved these changes Feb 22, 2024
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vtavana

@vtavana vtavana merged commit b8f051d into master Feb 22, 2024
@vtavana vtavana deleted the dpnp_inner branch February 22, 2024 20:04
github-actions bot added a commit to antonwolfy/dpnp that referenced this pull request Feb 23, 2024
@github-actions
update dpnp.inner implementation (IntelPython#1726)
69e19bb 
* update dpnp.inner

* address comments

* fix typo

---------

Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com> b8f051d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

Assignees

@vtavana vtavana

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vtavana @antonwolfy