Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dpnp.linalg.matrix_rank() implementation #1717

Merged
merged 9 commits into from
Feb 19, 2024
Merged

Update dpnp.linalg.matrix_rank() implementation #1717

merged 9 commits into from
Feb 19, 2024

Conversation

vlad-perevezentsev
Copy link
Collaborator

This PR updates dpnp.linalg.matrix_rank() function to calculate the matrix rank of input arrray using dpnp.linalg.svd()
The changes are related to support of all types and support of function arguments as hermitian

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 16, 2024 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

antonwolfy
antonwolfy reviewed Feb 16, 2024
View reviewed changes
dpnp/backend/kernels/dpnp_krnl_linalg.cpp Show resolved Hide resolved
dpnp/linalg/dpnp_iface_linalg.py Show resolved Hide resolved
dpnp/linalg/dpnp_utils_linalg.py Outdated Show resolved Hide resolved
dpnp/linalg/dpnp_utils_linalg.py Show resolved Hide resolved
tests/test_linalg.py Outdated Show resolved Hide resolved
antonwolfy
antonwolfy reviewed Feb 19, 2024
View reviewed changes
tests/test_linalg.py Outdated Show resolved Hide resolved
antonwolfy
antonwolfy approved these changes Feb 19, 2024
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vlad-perevezentsev

@antonwolfy antonwolfy merged commit d34b8ce into master Feb 19, 2024
44 of 45 checks passed
@antonwolfy antonwolfy deleted the impl_matrix_rank branch February 19, 2024 20:19
github-actions bot added a commit that referenced this pull request Feb 19, 2024
@github-actions
Update dpnp.linalg.matrix_rank() implementation (#1717)
d74194a 
* Update dpnp.linalg.matrix_rank impl

* Add cupy tests for dpnp.linalg.matrix_rank

* Add dpnp tests for dpnp.linalg.matrix_rank

* Remove old impl of dpnp_matrix_rank

* Address remarks

* Address remarks d34b8ce
github-actions bot added a commit to antonwolfy/dpnp that referenced this pull request Feb 20, 2024
@github-actions
Update dpnp.linalg.matrix_rank() implementation (IntelPython#1717)
79e7d3d 
* Update dpnp.linalg.matrix_rank impl

* Add cupy tests for dpnp.linalg.matrix_rank

* Add dpnp tests for dpnp.linalg.matrix_rank

* Remove old impl of dpnp_matrix_rank

* Address remarks

* Address remarks d34b8ce
@vlad-perevezentsev vlad-perevezentsev self-assigned this Mar 18, 2024
@antonwolfy antonwolfy mentioned this pull request Apr 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@npolina4 npolina4 Awaiting requested review from npolina4 npolina4 is a code owner

@vtavana vtavana Awaiting requested review from vtavana vtavana is a code owner

Assignees

@vlad-perevezentsev vlad-perevezentsev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vlad-perevezentsev @antonwolfy