Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add recipe-maintainers list #1682

Merged
merged 2 commits into from
Feb 4, 2024
Merged

Add recipe-maintainers list #1682

merged 2 commits into from
Feb 4, 2024

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Feb 4, 2024 •
edited
Loading

The PR adds maintainers to the conda recipe and defines summary to the same value as description has in setup.py.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Feb 4, 2024
vlad-perevezentsev
vlad-perevezentsev approved these changes Feb 4, 2024
View reviewed changes
Copy link
Collaborator

@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thank you @antonwolfy

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 4, 2024 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@antonwolfy antonwolfy merged commit da4df67 into master Feb 4, 2024
40 checks passed
@antonwolfy antonwolfy deleted the fix_maintainers branch February 4, 2024 13:02
github-actions bot added a commit that referenced this pull request Feb 4, 2024
@github-actions
Add recipe-maintainers list (#1682) da4df67
d720b85
@antonwolfy antonwolfy mentioned this pull request Feb 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vlad-perevezentsev vlad-perevezentsev vlad-perevezentsev approved these changes

@npolina4 npolina4 Awaiting requested review from npolina4 npolina4 is a code owner

@vtavana vtavana Awaiting requested review from vtavana vtavana is a code owner

Assignees

@antonwolfy antonwolfy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antonwolfy @vlad-perevezentsev